> On June 3, 2014, 4:30 p.m., rmudgett wrote: > > Actually, in generic_mute_unmute_helper() you don't need to distinguish > > between a user in the active_list or the waiting_list. If the user is in > > either list you can set the requested mute state. If the user is in the > > waiting_list that user will later join the conference in the requested mute > > state. This is how the startmuted option works. > > Andrew Nagy wrote: > I am willing to change the code there to make it work if the user is in > either active_live or waiting_list. Originally it was only checking > active_list, then I can just remove my extra help statements. Does that sound > like a plan?
Yes. That is what I am proposing. - rmudgett ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3582/#review12038 ----------------------------------------------------------- On June 3, 2014, 3:06 p.m., Andrew Nagy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3582/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 3:06 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > In confbridge when attempting to mute a user who is WaitMarked for Leader > wait the message from the CLI comes back as "No channel named > 'PJSIP/1000-00000015' found in conference 4000" which is confusing because > the channel is in the conference it's just not in the active list. > > My proposed solution is the patch attached to this file where I return a > message to both the CLI and the AMI if the user is wait marked. > > > Diffs > ----- > > /branches/12/apps/app_confbridge.c 415059 > > Diff: https://reviewboard.asterisk.org/r/3582/diff/ > > > Testing > ------- > > Tested Adding marked users and attempting to mute them, then tested with an > invalid channel and finally tested that regular muting still worked. > > > Thanks, > > Andrew Nagy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
