----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3584/#review12042 -----------------------------------------------------------
branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3584/#comment21981> Put this in its own method: update_connected_line(struct ast_sip_session *session); That will make this section of code much easier to read: if (res) { ast_queue_hangup(session->channel); } else { update_connected_line(session); ast_sip_session_send_request(session, tdata); } branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3584/#comment21982> You could save yourself a bit of processing here by checking id->self.number.valid/name.valid earlier: (Assuming this in its own function) if (!id->self.number.valid && !id->self.name.valid) { return; } - Matt Jordan On June 4, 2014, 8:07 a.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3584/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 8:07 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: DPMA-442 > https://issues.asterisk.org/jira/browse/DPMA-442 > > > Repository: Asterisk > > > Description > ------- > > This makes chan_pjsip send connected line information when it is called so > that connected line information is available on the connected channel. > > > Diffs > ----- > > branches/12/channels/chan_pjsip.c 415059 > > Diff: https://reviewboard.asterisk.org/r/3584/diff/ > > > Testing > ------- > > Made sure that connected line information was passed to the calling channel > correctly. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
