----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3584/#review12044 -----------------------------------------------------------
branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3584/#comment21984> You could refer to connected.id.number.valid instead. branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3584/#comment21985> You could refer to connected.id.name.valid instead. branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3584/#comment21983> This test is always true. You return at the beginning if neither is valid. branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3584/#comment21986> These could be grouped with the other connected struct initialization. - rmudgett On June 4, 2014, 9:05 a.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3584/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 9:05 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: DPMA-442 > https://issues.asterisk.org/jira/browse/DPMA-442 > > > Repository: Asterisk > > > Description > ------- > > This makes chan_pjsip send connected line information when it is called so > that connected line information is available on the connected channel. > > > Diffs > ----- > > branches/12/channels/chan_pjsip.c 415059 > > Diff: https://reviewboard.asterisk.org/r/3584/diff/ > > > Testing > ------- > > Made sure that connected line information was passed to the calling channel > correctly. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
