> On June 9, 2014, 7:23 p.m., Corey Farrell wrote:
> > /trunk/main/pbx.c, lines 7403-7404
> > <https://reviewboard.asterisk.org/r/3604/diff/1/?file=59450#file59450line7403>
> >
> > If we are going to have two lines per hint I think it needs to be
> > consistent. This way the eye's can easily follow the pattern of every
> > other line starting a new hint.
I know we did this for PJSIP, but 'core show hints' has been around a long
time. Bumping it two lines feels more disruptive than it needs to be.
Looking at the current output:
-= Registered Asterisk Dial Plan Hints =-
1000@default : PJSIP/alice State:InUse
Watchers 0
There's some space we can save by simply left justifying the output. The length
of the dialplan context/extension is probably a little large, and the amount of
space between State and Watchers could be shrunk. Unfortunately, the length of
space dedicated to the actual composition of the hint really needs to expand,
since it doesn't provide much room for "CustomPresence" to be shown.
>From a presence state perspective, we really only need the actual presence
>state. The subtype/message is nice information, but overkill for what
>typically amounts to a summary view.
Since presence state is often combined with device state, it could also be
formatted to show the presence state in with the 'State', i.e.:
State:InUse/available
State:Busy/dnd
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3604/#review12103
-----------------------------------------------------------
On June 9, 2014, 4:31 p.m., Scott Griepentrog wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3604/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 4:31 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: AFS-53
> https://issues.asterisk.org/jira/browse/AFS-53
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Allow inspection of presence information associated with hints via CLI
> command "core show hints".
>
>
> Diffs
> -----
>
> /trunk/main/pbx.c 415578
>
> Diff: https://reviewboard.asterisk.org/r/3604/diff/
>
>
> Testing
> -------
>
> Ran command and checked output.
>
>
> Thanks,
>
> Scott Griepentrog
>
>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
