----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3604/#review12118 -----------------------------------------------------------
/trunk/main/pbx.c <https://reviewboard.asterisk.org/r/3604/#comment22139> I don't see a reason for this buffer to be as large as it is. Given that AST_MAX_EXTENSION and AST_MAX_CONTEXT are both 80, you could get away with halving the size of the buffer. Furthermore, the ast_cli() invocation enforces a width of 20, so the 512 is going to get severely truncated anyway. /trunk/main/pbx.c <https://reviewboard.asterisk.org/r/3604/#comment22140> Any particular reason this line got changed? - Mark Michelson On June 10, 2014, 3:36 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3604/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 3:36 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: AFS-53 > https://issues.asterisk.org/jira/browse/AFS-53 > > > Repository: Asterisk > > > Description > ------- > > Allow inspection of presence information associated with hints via CLI > command "core show hints". > > Changes output format from: > > -= Registered Asterisk Dial Plan Hints =- > 1000@demo : SIP/1000 > State:Unavailable Watchers 0 > 1001@demo : SIP/1001 > State:Unavailable Watchers 0 > 1234@default : SIP/1234 > State:Unavailable Watchers 0 > ---------------- > - 3 hints registered > > > To: > > -= Registered Asterisk Dial Plan Hints =- > 1000@demo : SIP/1000 State:Unavailable > Presence:Idle Watchers 0 > 1001@demo : SIP/1001 State:Unavailable > Presence:Idle Watchers 0 > 1234@default : SIP/1234 State:Unavailable > Presence:Idle Watchers 0 > ---------------- > - 3 hints registered > > > Diffs > ----- > > /trunk/main/pbx.c 415578 > > Diff: https://reviewboard.asterisk.org/r/3604/diff/ > > > Testing > ------- > > Ran command and checked output. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
