-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3618/
-----------------------------------------------------------

(Updated June 18, 2014, 10:23 a.m.)


Review request for Asterisk Developers.


Changes
-------

Missed to update description of the patch to include dynamic ringbuffer size.


Bugs: ASTERISK-20696 and ASTERISK-23836
    https://issues.asterisk.org/jira/browse/ASTERISK-20696
    https://issues.asterisk.org/jira/browse/ASTERISK-23836


Repository: Asterisk


Description (updated)
-------

Target: app_jack.c

Enables the jack-audiohook to cope with dynamic sampling rates from and to 
Asterisk.
Information from channel is taken to derive the channel's sampling rate, 
suiting SLINxx format and frame->datalen.

Limitations:
* Required information is taken from channel during initialization as audiohook 
does not provide this information then. Audiohook.internal_sampl_rate(...) is 
set later, but no callback is available to inform app_jack.

* Frame.datalen is computed using "rate / 50" assuming a ptime of 20ms.
There is no internal API available to determine datalen for a SLINxx.

* Ringbuffer size is now dynamic depending frame.datalen (see above) and the 
number of frames, which are in RINGBUFFER_FRAME_CAPACITY, that need to fit.


Diffs
-----

  /trunk/apps/app_jack.c 415578 

Diff: https://reviewboard.asterisk.org/r/3618/diff/


Testing
-------

Checked with jackd and puredata using G.711 and G.722 on Ubuntu 14.0.4 64bit 
using Linphone and Ekiga.


Thanks,

Dennis Guse

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to