-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/
-----------------------------------------------------------
(Updated June 20, 2014, 11:24 a.m.)
Review request for Asterisk Developers.
Changes
-------
Uploaded diff for Asterisk 1.8. Proven to compile and run with some basic
testing.
Bugs: ASTERISK-23897
https://issues.asterisk.org/jira/browse/ASTERISK-23897
Repository: Asterisk
Description
-------
The change introduced in revision 413765 limits opening the media channel and
sending the PROGRESS control frame only to cases, when the Progress Indication
with value "Inband Info now available" is present in the SETUP ACK message.
However, there are exchanges (like Ericsson/Aastra MD110 BC13 or Avaya Definity
(revision unknown)), which don't send this PI in SETUP ACK, but they send
regular dial tone. Now the dial tone (and any subsequent audio information
until some progress indication is received from the PBX) cannot be heard. My
proposed solution is to introduce a new config option. I've called it
"alwayssendprogress" and it's a binary no/yes option. In the "no" status, it
keeps the new behaviour in place. In the "yes" status, it restores the old one.
A better naming is possible, any proposals are welcome.
The supplied patch was tested on current V11 SVN and it seems to be working as
expected.
Diffs
-----
/branches/11/configs/chan_dahdi.conf.sample 416805
/branches/11/channels/sig_pri.c 416805
/branches/11/channels/sig_pri.h 416805
/branches/11/channels/chan_dahdi.c 416805
/branches/11/UPGRADE.txt 416805
Diff: https://reviewboard.asterisk.org/r/3633/diff/
Testing
-------
Regularly using the patch on three systems with no visible problems.
File Attachments (updated)
----------------
Diff for Asterisk 1.8
https://reviewboard.asterisk.org/media/uploaded/files/2014/06/20/3c3b2124-78ce-41c8-b77f-e0bf4240b036__pri-1.8.diff
Thanks,
Pavel Troller
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
