> On June 20, 2014, 2:56 p.m., rmudgett wrote: > > /branches/11/UPGRADE.txt, lines 23-30 > > <https://reviewboard.asterisk.org/r/3633/diff/2/?file=59969#file59969line23> > > > > Changing UPGRADE is not necessary. This is fixing a regression. > > Documenting the new option is only needed in chan_dahdi.conf.sample.
I disagree (particularly since I told him to add it to UPGRADE.txt). The UPGRADE file is where people go to look for things that got added between revisions. Say, for example, I upgraded Asterisk and ran into this problem. Where would I go look to see what changed? I'm not going to diff every .conf file to find the updates. I may read through the (somewhat poorly formatted) ChangeLog, but commit messages are hardly targeted for every system administrator. No: you look at UPGRADE.txt. We've worked hard to get people to read it, and when something occurs that changes behaviour, you go read UPGRADE.txt to find out what it is. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/#review12257 ----------------------------------------------------------- On June 20, 2014, 6:24 a.m., Pavel Troller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3633/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 6:24 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23897 > https://issues.asterisk.org/jira/browse/ASTERISK-23897 > > > Repository: Asterisk > > > Description > ------- > > The change introduced in revision 413765 limits opening the media channel and > sending the PROGRESS control frame only to cases, when the Progress > Indication with value "Inband Info now available" is present in the SETUP ACK > message. However, there are exchanges (like Ericsson/Aastra MD110 BC13 or > Avaya Definity (revision unknown)), which don't send this PI in SETUP ACK, > but they send regular dial tone. Now the dial tone (and any subsequent audio > information until some progress indication is received from the PBX) cannot > be heard. My proposed solution is to introduce a new config option. I've > called it "alwayssendprogress" and it's a binary no/yes option. In the "no" > status, it keeps the new behaviour in place. In the "yes" status, it restores > the old one. > A better naming is possible, any proposals are welcome. > The supplied patch was tested on current V11 SVN and it seems to be working > as expected. > > > Diffs > ----- > > /branches/11/configs/chan_dahdi.conf.sample 416805 > /branches/11/channels/sig_pri.c 416805 > /branches/11/channels/sig_pri.h 416805 > /branches/11/channels/chan_dahdi.c 416805 > /branches/11/UPGRADE.txt 416805 > > Diff: https://reviewboard.asterisk.org/r/3633/diff/ > > > Testing > ------- > > Regularly using the patch on three systems with no visible problems. > > > File Attachments > ---------------- > > Diff for Asterisk 1.8 > > https://reviewboard.asterisk.org/media/uploaded/files/2014/06/20/3c3b2124-78ce-41c8-b77f-e0bf4240b036__pri-1.8.diff > > > Thanks, > > Pavel Troller > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
