----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3763/#review12625 -----------------------------------------------------------
I don't think these are equivalent. The code will do a compatible check but the format from the source won't go into the destination, as one is already there. This means that attribute information may get lost. - Joshua Colp On July 14, 2014, 2:42 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3763/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 2:42 p.m.) > > > Review request for Asterisk Developers, Corey Farrell and Matt Jordan. > > > Repository: Asterisk > > > Description > ------- > > When ast_format_cap_append was replaced with ast_format_cap_append_from_cap, > the behavior of the original function was not preserved. This change > introduces ast_format_cap_append_compatible_from_cap which reproduces the > original behavior of ast_format_cap_append and alters the original users of > ast_format_cap_append to use ast_format_cap_append_compatible_from_cap. > > The primary difference in behavior is that ast_format_cap_append_from_cap > appends unconditionally from the source format capability while > ast_format_cap_append checks for compatibility with > ast_format_cap_iscompatible. > > > Diffs > ----- > > team/group/media_formats-reviewed-trunk/res/res_pjsip_session.c 418507 > team/group/media_formats-reviewed-trunk/res/res_pjsip_sdp_rtp.c 418507 > team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418507 > team/group/media_formats-reviewed-trunk/addons/chan_ooh323.c 418507 > > Diff: https://reviewboard.asterisk.org/r/3763/diff/ > > > Testing > ------- > > Ensured that calling a channel via Dial() produced the same behavior as trunk. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
