----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3789/ -----------------------------------------------------------
(Updated July 14, 2014, 11:14 p.m.) Status ------ This change has been discarded. Review request for Asterisk Developers. Repository: Asterisk Description ------- This patch removes appending the capabilities from sip_cfg.caps to p->caps during the SIP pvt allocation. Without this patch, invalid offers that do not contain any matching codecs to a peer's definition will be accepted, as the pvt will have the default capabilities added to them. This causes the decline_incompat_audio.xml SIPp scenario to fail in the SDP_offer_answer test. As it turns out, it shouldn't be necessary to copy the formats from sip_cfg.caps to p->caps in the pvt constructor anyway. sip_new will already default back to sip_cfg.caps if there is no peer capabilities, and if there are no known capabilities in the pvt. Diffs ----- ./team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418614 Diff: https://reviewboard.asterisk.org/r/3789/diff/ Testing ------- All SIPp scenarios in SDP_offer_answer pass with this patch and the crash fix in r3788. Thanks, Matt Jordan
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
