----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3789/#review12662 -----------------------------------------------------------
Ship it! Ship It! - opticron On July 15, 2014, 9:10 a.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3789/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 9:10 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > When we first create a SIP pvt, we set the capabilities from the global > defaults, sip_cfg.caps. This is 'good', in the sense that if an end user (a) > doesn't configure much or (b) the peer definition doesn't have capabilities, > we use the defaults. > > Currently, however, when a peer is found, we simply append the capabililties > to the pvt. This has two problems: > (1) The peer may not have any capabilities > (2) If the peer does have capabilities, we simply append them to the dialog's > capabilities. This allows a dialog to have capabilities that were not > allowed. For example, since alaw is a 'default' capability, if a peer is > configured with ulaw only, the overall capabilities of the dialog will be > alaw|ulaw, and we would accept an INVITE request with alaw. > > This patch clears the dialog capabilities if a peer has capabilities. > > > Diffs > ----- > > ./team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418631 > > Diff: https://reviewboard.asterisk.org/r/3789/diff/ > > > Testing > ------- > > All SIPp scenarios in SDP_offer_answer pass with this patch and the crash fix > in r3788. > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
