----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12704 -----------------------------------------------------------
/trunk/res/res_smdi.c <https://reviewboard.asterisk.org/r/3758/#comment22982> The old code doesn't seem to remove the object from the container. /trunk/res/res_smdi.c <https://reviewboard.asterisk.org/r/3758/#comment22985> The old code doesn't seem to remove the object from the container. /trunk/res/res_smdi.c <https://reviewboard.asterisk.org/r/3758/#comment22983> Excess indention. /trunk/res/res_smdi.c <https://reviewboard.asterisk.org/r/3758/#comment22984> Yuck a shadowed variable. - rmudgett On July 16, 2014, 6:32 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3758/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 6:32 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This code converts res_smdi to use astobj2. > > * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, > ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, > ast_smdi_mwi_message destructor. > > The putback methods were unused and difficult to reimplement using > ao2_containers. > > Includes for astobj.h are removed everywhere it's possible. The only > remaining users are netsock.c (deprecated) and chan_sip (to be updated in a > separate review). > > > Diffs > ----- > > /trunk/res/res_smdi.c 418788 > /trunk/include/asterisk/smdi.h 418788 > /trunk/channels/sig_analog.c 418788 > /trunk/channels/chan_motif.c 418788 > /trunk/channels/chan_dahdi.c 418788 > /trunk/apps/app_voicemail.c 418788 > > Diff: https://reviewboard.asterisk.org/r/3758/diff/ > > > Testing > ------- > > Compile only (I do not have SMDI hardware). > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
