----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/ -----------------------------------------------------------
(Updated July 16, 2014, 9:29 p.m.) Review request for Asterisk Developers. Changes ------- Address Richards findings. Repository: Asterisk Description ------- This code converts res_smdi to use astobj2. * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, ast_smdi_mwi_message destructor. The putback methods were unused and difficult to reimplement using ao2_containers. Includes for astobj.h are removed everywhere it's possible. The only remaining users are netsock.c (deprecated) and chan_sip (to be updated in a separate review). Diffs (updated) ----- /trunk/res/res_smdi.c 418788 /trunk/include/asterisk/smdi.h 418788 /trunk/channels/sig_analog.c 418788 /trunk/channels/chan_motif.c 418788 /trunk/channels/chan_dahdi.c 418788 /trunk/apps/app_voicemail.c 418788 Diff: https://reviewboard.asterisk.org/r/3758/diff/ Testing ------- Compile only (I do not have SMDI hardware). Thanks, Corey Farrell
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
