> On July 18, 2014, 10:40 a.m., Mark Michelson wrote: > > /trunk/include/asterisk/res_pjsip.h, lines 1195-1203 > > <https://reviewboard.asterisk.org/r/3817/diff/2/?file=64713#file64713line1195> > > > > This function isn't necessary. When PJSIP is passed a URI string, PJSIP > > will perform URI validation for us and return an error if a badly-formed > > URI is passed in.
I was absolutely getting crashes when using URIs that didn't start with 'sip:' or else were only 'sip:' without anything appended to them. I'm not sure if that will keep being the case if we use the default endpoint like suggested below, but if it does then I might need to keep this around. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/#review12744 ----------------------------------------------------------- On July 17, 2014, 2:27 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3817/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 2:27 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and Mark Michelson. > > > Repository: Asterisk > > > Description > ------- > > Example: > > Action: PJSIPNotify > URI: sip:10.10.10.10 > > pjsip send notify uri <type> uri <uri> [uri...] > > > Adds the ability to use URIs with the PJSIP notify commands instead of > endpoints. These mostly work the same as the endpoint notifications. > > > Diffs > ----- > > /trunk/res/res_pjsip_notify.c 418783 > /trunk/res/res_pjsip.c 418783 > /trunk/include/asterisk/res_pjsip.h 418783 > > Diff: https://reviewboard.asterisk.org/r/3817/diff/ > > > Testing > ------- > > Used existing endpoint notification and compared it to similar notifies done > against URIs. The outgoing messages looked the same as far as the details I > was concerned with went. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
