----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12807 -----------------------------------------------------------
/trunk/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3759/#comment23135> Where are file, line, and func coming from? They don't seem to be passed in to sip_alloc. /trunk/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3759/#comment23137> Something seems off here. The ao2_t_ref() calls return ints and are parameters to AST_SCHED_REPLACE_UNREF(). Didn't registry_unref() return a pointer? /trunk/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3759/#comment23138> Idem /trunk/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3759/#comment23139> Idem /trunk/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3759/#comment23140> You should get a iterator ref for ast_sched_add() before calling it and unref if it fails to be added. Otherwise, you run the risk of iterator being stale when ast_sched_add succeeds. - rmudgett On July 21, 2014, 10:52 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3759/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 10:52 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24067 > https://issues.asterisk.org/jira/browse/ASTERISK-24067 > > > Repository: Asterisk > > > Description > ------- > > Upgrade all ASTOBJ objects in chan_sip to ao2. > > > Diffs > ----- > > /trunk/channels/sip/include/sip.h 419127 > /trunk/channels/chan_sip.c 419127 > > Diff: https://reviewboard.asterisk.org/r/3759/diff/ > > > Testing > ------- > > Full testsuite run. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
