> On July 22, 2014, 11:24 a.m., rmudgett wrote: > > /trunk/channels/chan_sip.c, lines 15568-15571 > > <https://reviewboard.asterisk.org/r/3759/diff/4/?file=64989#file64989line15568> > > > > Something seems off here. The ao2_t_ref() calls return ints and are > > parameters to AST_SCHED_REPLACE_UNREF(). Didn't registry_unref() return a > > pointer? > >
The scheduler macros don't actually use return values for any of these. They exist only to ref or unref the given variable if the scheduler macro deems it necessary. - opticron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12807 ----------------------------------------------------------- On July 21, 2014, 10:52 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3759/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 10:52 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24067 > https://issues.asterisk.org/jira/browse/ASTERISK-24067 > > > Repository: Asterisk > > > Description > ------- > > Upgrade all ASTOBJ objects in chan_sip to ao2. > > > Diffs > ----- > > /trunk/channels/sip/include/sip.h 419127 > /trunk/channels/chan_sip.c 419127 > > Diff: https://reviewboard.asterisk.org/r/3759/diff/ > > > Testing > ------- > > Full testsuite run. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
