> On March 27, 2015, 2:26 p.m., Matt Jordan wrote: > > I think your solution here is fine.
Hi Matt, can i commit directly to the svn repository or does someone have to do this for me. Your 'ship it' gives the impression that i can. If so is there a particular format to which the commit message has to adhere. Should it include the reviewboard number / bug report issue etc ? If not, and someone else will be doing the actual commit it would be nice if my name would be mentioned ;-) - Diederik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4539/#review14898 ----------------------------------------------------------- On March 27, 2015, 12:41 p.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4539/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 12:41 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > clang's static analyzer will throw quite a number warnings / errors during > compilation, some of which can be very helpfull in finding corner-case bugs. > > clang compiler warning:-Winitializer-overrides > > Issue: > res_pjsip/config_transport.c:382:25: warning: initializer overrides prior > initialization of this subobject [-Winitializer-overrides] > [PJSIP_TLSV1_METHOD] = "tlsv1", > res_pjsip/config_transport.c:380:31: note: previous initialization is here > [PJSIP_SSL_DEFAULT_METHOD] = "default", > > Possible Solutions: > 1. PJSIP_SSL_DEFAULT_METHOD is defined as PJSIP_TLSV1_METHOD -> remove the > offending initializer in line 380 > 2. define PJSIP_SSL_DEFAULT_METHOD locally (overriding the default define > from /usr/include/pjsip/sip_transport_tls.h) and use a different value for it. > > Not sure which method would be preferred, leaving that decision to the code > owner. > > > Diffs > ----- > > /branches/13/res/res_pjsip/config_transport.c 433444 > > Diff: https://reviewboard.asterisk.org/r/4539/diff/ > > > Testing > ------- > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
