> On March 27, 2015, 8:26 a.m., Matt Jordan wrote: > > I think your solution here is fine. > > Diederik de Groot wrote: > Hi Matt, can i commit directly to the svn repository or does someone have > to do this for me. > Your 'ship it' gives the impression that i can. If so is there a > particular format to which the commit message has to adhere. Should it > include the reviewboard number / bug report issue etc ? If not, and someone > else will be doing the actual commit it would be nice if my name would be > mentioned ;-)
I'm actually running through some commits this morning. A number of developers with commit access will commit things that have been Shipped periodically - we usually get them within a few days after they're shipped. Attribution is given in the commit messages: r433678 | mjordan | 2015-03-28 07:17:45 -0500 (Sat, 28 Mar 2015) | 13 lines clang compiler warnings: Fix -Wunused-function This patch fixes clang compilers warnings for unused functions. Specifically: * channels/chan_iax2: removed user_ref function * main/dsp.c: removed goertzel_update function Review: https://reviewboard.asterisk.org/r/4527 ASTERISK-24917 Reported by: dkdegroot patches: rb4527.patch submitted by dkdegroot (License 6600) Scripts in the project that build out the release summaries attribute who wrote the patch based on the 'submitted by' tag in the commit message. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4539/#review14898 ----------------------------------------------------------- On March 27, 2015, 6:41 a.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4539/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 6:41 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > clang's static analyzer will throw quite a number warnings / errors during > compilation, some of which can be very helpfull in finding corner-case bugs. > > clang compiler warning:-Winitializer-overrides > > Issue: > res_pjsip/config_transport.c:382:25: warning: initializer overrides prior > initialization of this subobject [-Winitializer-overrides] > [PJSIP_TLSV1_METHOD] = "tlsv1", > res_pjsip/config_transport.c:380:31: note: previous initialization is here > [PJSIP_SSL_DEFAULT_METHOD] = "default", > > Possible Solutions: > 1. PJSIP_SSL_DEFAULT_METHOD is defined as PJSIP_TLSV1_METHOD -> remove the > offending initializer in line 380 > 2. define PJSIP_SSL_DEFAULT_METHOD locally (overriding the default define > from /usr/include/pjsip/sip_transport_tls.h) and use a different value for it. > > Not sure which method would be preferred, leaving that decision to the code > owner. > > > Diffs > ----- > > /branches/13/res/res_pjsip/config_transport.c 433444 > > Diff: https://reviewboard.asterisk.org/r/4539/diff/ > > > Testing > ------- > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
