----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4596/#review15085 -----------------------------------------------------------
branches/13/res/res_pjsip_config_wizard.c <https://reviewboard.asterisk.org/r/4596/#comment25764> I'm concerned that this is needed due to the load order change. My worry is that there might be other modules that will need this due to res_pjsip_config_wizard loading later. I'm not confident enough with my knowledge of res_pjsip modules to say if this is ok. - Corey Farrell On April 6, 2015, 4:32 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4596/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 4:32 p.m.) > > > Review request for Asterisk Developers and Corey Farrell. > > > Bugs: ASTERISK-24935 > https://issues.asterisk.org/jira/browse/ASTERISK-24935 > > > Repository: Asterisk > > > Description > ------- > > Original issue: res_pjsip_phoneprov_provider was using ao2_callback with > OBJ_MULTIPLE, then ignoring the return. This resulted in a reference leak. > Added OBJ_NODATA flag. > > Unfortunately, this highlighted a module unload order issue where > res_phoneprov and res_pjsip_phoneprov_provider were unloading before > res_pjsip_config_wizard, which needed them. > > res_pjsip_config_wizard is itself a sorcery wizard so there are some > complexities to it's load order (it's long story) but I've removed the > GLOBAL_SYMBOLS flag from res_pjsip_config_wizard so it loads later and > unloads earlier and also triggered a reload of res_pjsip_phoneprov_provider. > Now they load and unload in the correct order. > > > Diffs > ----- > > branches/13/res/res_pjsip_phoneprov_provider.c 434148 > branches/13/res/res_pjsip_config_wizard.c 434148 > > Diff: https://reviewboard.asterisk.org/r/4596/diff/ > > > Testing > ------- > > Checked load/unload order and make sure there were no FRACKs on unload. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
