----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4596/#review15136 -----------------------------------------------------------
So this change does fix the leak I was originally concerned with, and does not cause any FRACK's for me. Unfortunately I have very poor understanding of sorcery so I think we need someone else to review that portion and give approval. branches/13/res/res_pjsip_config_wizard.c <https://reviewboard.asterisk.org/r/4596/#comment25797> Since this code is being moved lets remove the RAII_VAR and just put ao2_cleanup at the end of the loop. RAII_VAR adds overhead so we shouldn't use it in loops like this one. - Corey Farrell On April 8, 2015, 2:09 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4596/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 2:09 p.m.) > > > Review request for Asterisk Developers and Corey Farrell. > > > Bugs: ASTERISK-24935 > https://issues.asterisk.org/jira/browse/ASTERISK-24935 > > > Repository: Asterisk > > > Description > ------- > > Original issue: res_pjsip_phoneprov_provider was using ao2_callback with > OBJ_MULTIPLE, then ignoring the return. This resulted in a reference leak. > Added OBJ_NODATA flag. > > Unfortunately, this highlighted a module unload order issue where > res_phoneprov and res_pjsip_phoneprov_provider were unloading before > res_pjsip_config_wizard, which needed them. > > res_pjsip_config_wizard is itself a sorcery wizard so there are some > complexities to it's load order (it's long story) but I've removed the > GLOBAL_SYMBOLS flag from res_pjsip_config_wizard so it loads later and > unloads earlier and also triggered a reload of res_pjsip_phoneprov_provider. > Now they load and unload in the correct order. > > > Diffs > ----- > > branches/13/res/res_pjsip_phoneprov_provider.c 434423 > branches/13/res/res_pjsip_config_wizard.c 434423 > > Diff: https://reviewboard.asterisk.org/r/4596/diff/ > > > Testing > ------- > > Checked load/unload order and make sure there were no FRACKs on unload. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
