Agreed. The scripts are a mess, and someone should file a bug and (preferably) submit fixes. David is pretty good about getting new releases out.
The scripts are part of rp-pppoe, I believe, and not pppd. Also, we install the pppoe scripts pretty much unmodified (for better or worse). -Philip Terry Markovich wrote: > Yes, it is the standard symlink. The issue is the redefinition of > $CONFIG for the pppoe scripts (/usr/sbin/pppoe-start, etc). > > The default config location for these scripts is /etc/ppp/pppoe.conf > (doesn't matter if it is a symlink or not). > > The network init script writes the values out to the correct file, but > defines $CONFIG in this same file to /etc/ppp > > Since the network init script puts the config file in the default > location, the CONFIG variable is not needed. Not sure why CF_BASE is in > there, as none of the pppoe scripts use it. It looks like the intention > was for CONFIG to be combined with CF_BASE for the full path (and maybe > an earlier rp-pppoe package expected this?), but this is not happening. > > Terry > > Philip Prindeville wrote: > >> Terry Markovich wrote: >> >>> I have found an error in the >>> /trunk/target/generic/target_skeleton/etc/init.d/network script >>> regarding PPPoE. >>> >>> The script writes to /tmp/etc/ppp/pppoe.conf >>> >>> CONFIG=\"/etc/ppp\" >>> CF_BASE=\"pppoe.conf\" >>> >>> The problem is that $CONFIG is used all over the pppoe-start and >>> pppoe-status scripts, so $CONFIG gets reassigned from it's default of >>> /etc/ppp/pppoe.conf, pppoe-status fails for a missing config and then >>> the pppoe-start times out, although PPPoE is actually running. No pid >>> files get created so it does not even shutdown pppd/pppoe when it fails. >>> >>> Removing both of these variables from the network script works for me, >>> pid files are created and it does not complain about a timeout. >>> >>> Terry Markovich >>> >>> >> Isn't /etc/ppp a symlink to /tmp/etc/ppp on your system? >> >> Or is there a separate issue to this? >> >> I remember looking at the PID issue before, and it struck me that it was >> caused by inconsistent naming in the filenames. I.e. what got created >> and what was checked for weren't the same. >> >> -Philip >> ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Astlinux-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/astlinux-users Donations to support AstLinux are graciously accepted via PayPal to [EMAIL PROTECTED]
