On Sat, 2019-08-10 at 17:36 +0530, Tamizh chelvam wrote:
>
> > > + [NL80211_TID_ATTR_CONFIG_RETRY] = { .type = NLA_FLAG },
> > > + [NL80211_TID_ATTR_CONFIG_RETRY_SHORT] = NLA_POLICY_MIN(NLA_U8, 0),
> > > + [NL80211_TID_ATTR_CONFIG_RETRY_LONG] = NLA_POLICY_MIN(NLA_U8, 0),
> >
> > min of 0 doesn't make sense, maybe you meant 1? otherwise just don't
> > set
> > anything here.
> >
> The min value changed to 0 from 1 as per the previous discussions, since
> this is a retry count and not a tx count.
> Or Shall I remove this min value to avoid the confusion ?
Yeah, I think then you should just remove the min value. Perhaps a max
value is needed, but I don't know.
> > > + tid_conf->retry_short = -1;
> > > +
> >
> > I guess you should document that -1 means no changes? Not sure how the
> > IEEE80211_TID_CONF_RETRY comes in, you're always setting it, so that's
> > useless - better remove that and document that -1 means no changes?
> >
> The value -1 is to notify the driver to use default value by removing
> peer specific retry count.
Oh. So I think that's slightly different, please document that.
johannes
