For some reason these comments didn't go to patchwork so resending them again:
Kalle Valo <[email protected]> writes: > Yu Wang <[email protected]> writes: > >> + for (i = 0; i < sband->n_bitrates; i++) { >> + bitrates = &sband->bitrates[i]; >> + if (ath10k_mac_bitrate_is_cck(bitrates->bitrate) != cck) >> + continue; >> + >> + if (bitrates->hw_value == hw_rate || >> + (bitrates->flags & IEEE80211_RATE_SHORT_PREAMBLE && >> + bitrates->hw_value_short == hw_rate)) { >> + bitrate = bitrates->bitrate; >> + >> + /* The bitrate will be recovered in >> + * ath10k_update_per_peer_tx_stats(). >> + */ >> + if (bitrate == 55) >> + bitrate = 60; >> + >> + bitrate = bitrate / 10; > > Here you use magic value 60 but in ath10k_update_per_peer_tx_stats() you > use magic value 50: > >> + /* from 1Mbps to 100Kbps */ >> + rate = rate * 10; >> + if (rate == 50) >> + rate = 55; > > Am I missing something or how is this supposed to work? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
