On Sat, Jan 24, 2015 at 11:23 AM, Kalle Valo <kv...@codeaurora.org> wrote:
> Hong Xu <h...@topbug.net> writes:
>
>> ath9k and ath9k_htc use the variable name "led_blink" to indicate
>> whether the module parameter "blink" is on. This name is easy to
>> conflict with other variables, thus they are renamed.
>
> Please state clearly that this fixes a compiler error found by kbuild.
> Also it's very much recommended to add the actual compiler error to the
> commit log:
>
> drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple definition
> of `led_blink'
> drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here
>
Some more things...
If you post a vN (referring to your v3) of a patch, please add a
history of changes.
2nd, use the Fixes tag [2] in this case with a reference to the
culprit commit [1].
Fixes: 3a939a671225 ("ath9k_htc: Add a module parameter to disable blink")
Last but not least, honour credits like Reported-by/Tested-by (plus
some infos like broken in Linux-next $VERSION).
- Sedat -
[1]
http://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=3a939a671225909c19b09bfcb6e4761109e913d9
[2]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n159
_______________________________________________
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
