On Sat, Jan 24, 2015 at 11:38 AM, Oleksij Rempel <li...@rempel-privat.de> wrote: > Am 24.01.2015 um 11:33 schrieb Sedat Dilek: >> On Sat, Jan 24, 2015 at 11:23 AM, Kalle Valo <kv...@codeaurora.org> wrote: >>> Hong Xu <h...@topbug.net> writes: >>> >>>> ath9k and ath9k_htc use the variable name "led_blink" to indicate >>>> whether the module parameter "blink" is on. This name is easy to >>>> conflict with other variables, thus they are renamed. >>> >>> Please state clearly that this fixes a compiler error found by kbuild. >>> Also it's very much recommended to add the actual compiler error to the >>> commit log: >>> >>> drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple >>> definition of `led_blink' >>> drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here >>> >> >> Some more things... >> >> If you post a vN (referring to your v3) of a patch, please add a >> history of changes. > > What kind of history do you wont to have here? Kernel log should not be > overloaded with patch preparation history. >
Not here. Referring to "[PATCH v3] ath9k_htc: Add a module parameter to disable blink". And no, the history of changes are 1. important 2. not in the "commit-body", so you will not see them when the patch is pushed to the appropriate Git tree. - Sedat - _______________________________________________ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
