-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [EMAIL PROTECTED] wrote: > Jeff Mahoney: >> Ok, yeah. fput() expects the file to have an instantiated dentry, which >> may not exist. I've switched the code to use release_open_intent instead >> and exported that in our kernel. > > Essentially your approch has no difference from current code. Of course, > I don't think it bad. Calling release_open_intent() may be more > promising.
Agreed, I just think you'll have better luck trying to get that function exported instead of put_filp. >> As for the lookup_one_len vs __lookup_hash issue, have you run into >> problems with NFS2/3 as well as NFSv4? nfs_lookup looks like it can deal >> with a NULL nameidata. NFSv4's nfs_atomic_lookup most definitely can't. > > Yes, there WAS a problem. > I've checked the history of fs/nfs/dir.c now and found the reference to > nameidata in nfs_lookup() was removed in linux-2.6.23. If you read > fs/nfs/dir.c in 2.6.22 or older, you would know nfs_lookup() required > non-NULL nameidata. > Anyway I understand I should change several things in aufs/fs/aufs25 > based upon your patch, including Kconfig.in and sysfs.c too probably. Ok, that works then. I'm only working with the post-2.6.25 tree anyway. >> I wonder because while I'm keen to support NFS with aufs on openSUSE, >> but NFS4 isn't as much of a concern on LiveCDs. > > Unfortunately or fortunately, aufs is used in several fields other than > live cd. :-) > Actually I had bug reports or requests around nfsv4. > (But I don't know they are still using aufs with nfsv4) Oh, I agree. I'm not proposing killing NFSv4 support at all, or even the atomic open functionality. For my purposes as one of the openSUSE kernel maintainers, LiveCDs are the functionality we're after. To that end, I'm fine with disabling NFSv4 support for our kernels. I'd like to enable it later if there is a way to do so without requiring internal functions be exported. > By the way, it is Wednesday which is weekly feature freeze day I set. > So your patches will be merged two weeks later. Some of them will be > changed slightly, but the others will not. > Anyway I appriciate your patches. Great. We're fairly late in our release cycle for openSUSE 11.1, so I've added these patches to our aufs package already. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkkA2V0ACgkQLPWxlyuTD7KO9wCeIwiwA47NJe+HKJdeRTFc9HXt w8cAnRRivv3kA0gf00e89PCJl1tX94XV =zL4i -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
