On Wed October 22 2008, [EMAIL PROTECTED] wrote:
> "James .":
> > Behaviour which i dont think is correct: I noticed that the unioned
> > filesystem often misses some inotify events (or whatever you would call it)
> > when new files are created. I have to "refresh" on my nautilus browser every
> > time to see the new files, and when it happens, the directory will never
> > update itself for the rest of the session. It is very easy to reproduce.
>
> I have found a suspicious code in linux-2.6.27/fs/inotify_user.c.
> Will you try this patch? If it fixes your problem, then what you met is
> not an aufs bug. If not, there may be a bug somewhere else.
>
Was diddling with the code to give the above a try and the eyes noticed this:
(in inotify_read function above the patched one)
while (1) {
prepare_to_wait(&dev->wq, &wait, TASK_INTERRUPTIBLE);
mutex_lock(&dev->ev_mutex);
if (!list_empty(&dev->events)) {
ret = 0;
break;
}
mutex_unlock(&dev->ev_mutex);
Which skips the unlock if the list is not empty; continuing in the code;
where there are various conditional paths that look as if it can be unlocked
twice.
Warning: My "C" skills are at a low ebb - someone else please take a look.
Mike
>
> Junjiro R. Okajima
>
>
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
