Hello,

> 0a) Revert the change to set BIN_SH in Autoconf, [...]

IMHO this is a very good idea.

First, BIN_SH is set in macro AS_BOURNE_COMPATIBLE, but it doesn't belong
there: this macro contains things like "set -o posix", which
 i) have an immediate effect inside the current instance
 ii) are not inhereted in subsequent calls to the shell

(Because of (ii), AS_BOURNE_COMPATIBLE is called from _AS_RUN.)

Second, if this change

> 0b) Additionally, prepend /usr/bin/posix/ to the path walk of
> _AS_DETECT_BETTER_SHELL, [...]

make things work on OSF, then the BIN_SH assignment becomes redundant
cruft, right?

We shall remove it now, before is is conserved by a release.

(If the problem re-appears when 2.60 will be widely used, we can then
add BIN_SH to the right place (the "detect better shell" stuff), and
with a comment explaining the situation where it was necessary.)

Does this sound convincing?

Moreover, I think that the line
        DUALCASE=1; export DUALCASE
doesn't belong to AS_BOURNE_COMPATIBLE either, the reason is the same
as above; I think it shall go to AS_SHELL_SANITIZE.

These two changes would make the following patch; OK to commit?

Have a nice day,
        Stepan
2006-03-17  Stepan Kasal  <[EMAIL PROTECTED]>

        * lib/m4sugar/m4sh.m4 (AS_BOURNE_COMPATIBLE): Removed BIN_SH=xpg4,
          moved DUALCASE=1 ...
        (AS_SHELL_SANITIZE): ... here.

Index: lib/m4sugar/m4sh.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/m4sugar/m4sh.m4,v
retrieving revision 1.162
diff -u -r1.162 m4sh.m4
--- lib/m4sugar/m4sh.m4 16 Mar 2006 13:33:18 -0000      1.162
+++ lib/m4sugar/m4sh.m4 17 Mar 2006 15:20:12 -0000
@@ -172,8 +172,6 @@
 else
   case `(set -o) 2>/dev/null` in *posix*) set -o posix;; esac
 fi
-BIN_SH=xpg4; export BIN_SH # for Tru64
-DUALCASE=1; export DUALCASE # for MKS sh
 ])
 
 
@@ -320,6 +318,7 @@
 ## --------------------- ##
 
 AS_BOURNE_COMPATIBLE
+DUALCASE=1; export DUALCASE # for MKS sh
 
 # PATH needs CR
 _AS_CR_PREPARE

Reply via email to