Hi Stepan, * Stepan Kasal wrote on Thu, Apr 06, 2006 at 03:25:25PM CEST: > On Thu, Apr 06, 2006 at 02:08:27PM +0200, Ralf Wildenhues wrote: > > I also think BIN_SH should be set in AS_BOURNE_COMPATIBLE, not in > > AS_SHELL_SANITIZE, but am less certain about that. > > yes, you are probably right. But it's even more clear that the > DUALCASE really belongs there: the documentation says that > AS_BOURNE_COMPATIBLE makes the shell more compatible with Bourne > shell, and DUALCASE immediately affects the running shell.
This is ok. > But these two settings are not needed inside _AS_RUN, which is why > I moved them out of AS_BOURNE_COMPATIBLE previously. This, again, is micro-optimization. Let's remember we're trying to stabilize things here, so let's just dump all optimization and other non-bugfixing work such as needless usage of AS_IF (after all, this is a small code block that is verbatim copied into the output). OK? Cheers, Ralf > 2006-04-06 Stepan Kasal <[EMAIL PROTECTED]> > > * lib/m4sugar/m4sh.m4 (AS_SHELL_SANITIZE): Do not set DUALCASE. > (AS_BOURNE_COMPATIBLE): Set it here, and set BIN_SH=xpg4, factor out > the rest... > (_AS_BOURNE_COMPATIBLE): ... to this new macro. > (_AS_RUN): Call _AS_BOURNE_COMPATIBLE instead of AS_BOURNE_COMPATIBLE. > * doc/autoconf.texi (Special Shell Variables) <BIN_SH>: Document that > we set it again.
