Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes:

> FWIW, I haven't looked at the patch in detail, but it's ok with me
> if we warn about literal newlines, even if we don't for non-literal
> ones (passed through a shell variable with AC_DEFINE_UNQUOTED), as
> long as we don't advertise this safeguard.  So please go ahead.

OK, committed[1].  You are right that it is not possible to warn if 
AC_DEFINE_UNQUOTED passes a shell variable with bogus content; here, the 
documentation should be adequate (just like we don't warn if the value contains 
`#' but the user didn't use AC_CONFIG_HEADER, where make will eat the # out of 
@DEFS@).

[1] http://git.sv.gnu.org/gitweb/?p=autoconf.git;a=commitdiff;h=baa0ce0

-- 
Eric Blake




Reply via email to