Hi Jim, All fine with me except nits:
* Jim Meyering wrote on Sat, Oct 27, 2007 at 07:38:23PM CEST: [...git-version-gen...] > + COREUTILS-[0-9]*) v=`echo "$v" | sed 's/^COREUTILS-//;s/_/./g'` ;; Does that need adjustment for Autoconf? [...] > diff --git a/tests/Makefile.am b/tests/Makefile.am > index c1141c6..1972d6c 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -34,7 +34,7 @@ include ../lib/freeze.mk > ## package.m4. ## > ## ------------ ## > > -$(srcdir)/package.m4: $(top_srcdir)/configure.ac > +$(srcdir)/package.m4: $(builddir)/Makefile Please make that `Makefile', not `$(builddir)/Makefile'. Non-GNU make don't all identify `file' with `./file'. * Jim Meyering wrote on Sat, Oct 27, 2007 at 08:11:39PM CEST: > > I suppose we should be using gnulib-tool to pull in > build-aux files, including announce-gen. Why? Except for announce-gen, all files are installed by `automake -a'. Cheers, Ralf
