Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > Hi Jim, > > * Jim Meyering wrote on Mon, Aug 18, 2008 at 11:23:01AM CEST: >> I admit that this not a big deal, but even when I interrupt a configure >> script, I prefer to see it die cleanly. Otherwise, I have to wonder >> if some clean-up trap code also fails to run. >> >> Comments, suggestions ? > > Doesn't this patch hide potential typos otherwise exposed by the `test' > error? AIUI gnulib uses this idiom a lot.
Good point! Here's an incremental to fix that: diff --git a/lib/m4sugar/m4sh.m4 b/lib/m4sugar/m4sh.m4 index afa747a..bc2a919 100644 --- a/lib/m4sugar/m4sh.m4 +++ b/lib/m4sugar/m4sh.m4 @@ -1548,7 +1548,7 @@ m4_define([AS_VAR_SET], # -------------------- # test whether VARIABLE has value "yes". m4_define([AS_VAR_YES], -[as_yes=AS_VAR_GET([$1]); test "x$as_yes" = xyes]) +[as_yes=AS_VAR_GET([$1]); test "$as_yes" = yes]) # AS_VAR_GET(VARIABLE)
