* Jim Meyering wrote on Mon, Aug 18, 2008 at 12:12:29PM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > > > > Doesn't this patch hide potential typos otherwise exposed by the `test' > > error? AIUI gnulib uses this idiom a lot. > > Good point! > Here's an incremental to fix that:
I don't see how that would improve things, sorry. (I can only actually test things tonight though, so this is from looking at your patch only.) Maybe all you want to prevent is errors from inside the trap code? Cheers, Ralf > --- a/lib/m4sugar/m4sh.m4 > +++ b/lib/m4sugar/m4sh.m4 > @@ -1548,7 +1548,7 @@ m4_define([AS_VAR_SET], > # -------------------- > # test whether VARIABLE has value "yes". > m4_define([AS_VAR_YES], > -[as_yes=AS_VAR_GET([$1]); test "x$as_yes" = xyes]) > +[as_yes=AS_VAR_GET([$1]); test "$as_yes" = yes])
