==> Regarding Re: [autofs] [RFC] rpc_ping and looong timeouts; [EMAIL PROTECTED] adds:
raven> On Fri, 4 Jun 2004, Jeff Moyer wrote: >> [snip] >> One nit: icmp_ping_host takes a char * for the hostname, whereas >> rpc_ping passes a const char *. As such, we get a 'discards qualifier' >> warning. I didn't think it warrented converting the whole call chain to >> consts, but if you're especially concerned about that, Ian, I'd be happy >> to resubmit. >> raven> I'll see if I can get rid of the warning in some simple way. If only raven> as a clear indication it's what we intended to do. raven> In fact I will be able to use this to make the umount smarter later raven> some time. Cool. >> Comments? raven> I've only had a brief look at the patch but it looks like good clean raven> code. raven> One small thing though. raven> I understand you need to attribute Copyright to Redhat but don't you raven> think it would be acceptable to add your name their as well? Heh. Well, I didn't write the ping code (only modified it to make the timeouts finer granularity). Lon Hohberger wrote it. I'll be sure to pass along your kudos (and suggestion). ;) -Jeff _______________________________________________ autofs mailing list [EMAIL PROTECTED] http://linux.kernel.org/mailman/listinfo/autofs
