On Wed, 30 Jun 2004, Jeff Moyer wrote:

> >+            if (!strcmp(curfstype, "cachefs")) {
> >+                    /* cachefs not supported for Linux.  We do not even try 
> >because when
> >+                       we try, mount will complain about the module being absent.  
> >This is
> >+                       not desired because if backfstype parameter is provided and 
> >works,
> >+                       we sure do not want any error messages reported to syslog. 
> >*/
> >+                    debug("cachefs not implemented under Linux and thus ignored.");
> >+                    continue;
> >+            }
> >+#endif
> 
> Don't need the ifdef.  Also, try to keep w/in 80 columns, please.

We know it's hard to keep within 80 cols. I constantly try to rearrange 
code to try and achieve this.

> >+            if(!rv)
> >+            {
> >+                    break;
> >+            }
> 
> Keep to coding style:  { on same line as if.

The document in the kernel source is an excellent guide to what to try to 
achieve coding standards.

<kernel source dir>/Documentation/CodingStyle

Ian

_______________________________________________
autofs mailing list
[EMAIL PROTECTED]
http://linux.kernel.org/mailman/listinfo/autofs

Reply via email to