On Thu, Jan 13, 2011 at 11:20 PM, David Howells <dhowe...@redhat.com> wrote:
> Nick Piggin <npig...@gmail.com> wrote:
>
>> So something has gone wrong here. You have documented .d_automount
>> can be called in rcu-walk mode, but it doesn't seem to be the case.
>
> Ah.  You removed a column and installed a new one, and I didn't notice.

You still have to notice that it is .d_automount in rcu-walk mode, and bail
out if it is. I can't see where you do that.


> Neither d_automount() and d_manage() should be entered in rcu-walk mode since
> they're both expected to sleep.
>
> Btw, should you add a fifth column for d_seq?

rcu-walk means that rcu_read_lock is held, d_seq is open, vfsmount_lock is
held for read. So it's redundant.

> I should also add a column for namespace_sem as d_manage() may be called with
> that held (and d_automount() must not be called with that held).

More documentation the merrier.

_______________________________________________
autofs mailing list
autofs@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/autofs

Reply via email to