On Fri, Jan 14, 2011 at 12:19:43PM +1100, Nick Piggin wrote:
> Also, I don't like how you return a vfsmount * and use that in path walking.
> If
> you just returned success and allowed the path walk to continue looking up
> mounted directories, it would be cleaner code, IMO.
No. Filesystem has no business touching mount tree; leave that to core VFS.
Analysis of what's going on is messy enough as it is, let's *NOT* complicate
it even further.
I think we should take do_add_mount() calls into follow_automount(), making
the API
NULL => nothing to do here, just follow mount
ERR_PTR() => sod off
mnt => here's the thing I want mounted, do it and go there. If
something's allready got mounted here, just disregard this one and follow
mount as usual (== we'd lost the race)
_______________________________________________
autofs mailing list
autofs@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/autofs
