Hi Chris:
Thanks for your suggestion,I agree most of them.
But I think there is no need to change the following 2 places.
1.ret = libvirt_vm.virsh_domxml_from_native(vm_ref, ignore_status=True)
status = ret.exit_status
You mentioned "I'd recommend wrapping this in a try: / except: block, or
somehow otherwise making sure if there are problems, the libvirtd service
is restored as expected."
I had added a parameter "ignore_status= True" which can make the function
ignore exception.So I think the libvirtd service will be restored as
expected.
2.def virsh_convxml(vm_name, guest_args):
You mentioned "I wonder if this function would be good to make more for
general use, and put into client/virt/libvirt_xml.py module."
In the virsh_convxml function, I haven't changed any XML file, just output
infomation this test needs. Maybe the name of the function is confusing, and
I will change it. And I think the infomation outputed is not enough useful
for general use. Because of this, I think it not need to change.
That's my opinion, what do you think?
On 2012-8-30 1:52, Chris Evich wrote:
On 08/28/2012 06:13 AM, liyang wrote:
Hi Chris,Lucas:
This patch which includes 3 files tests "virsh domxml-from-native"
command.
The test contains six cases.
Li Yang (3):
virt/libvirt_vm.py: add virsh function for virsh domxml-from-native.
virt/subtests.cfg.sample: add config for virsh domxml-from-native.
tests/libvirt/tests: add test file for virsh domxml-from-native.
.../libvirt/tests/virsh_domxml_from_native.py | 104 ++++++++++++++++++++
client/virt/libvirt_vm.py | 8 ++
client/virt/subtests.cfg.sample | 31 ++++++
3 files changed, 143 insertions(+), 0 deletions(-)
create mode 100644
client/tests/libvirt/tests/virsh_domxml_from_native.py
Li,
I posted a full review of these patches on the github topic-issue you
opened (thanks!). Just mentioning it here in case you don't receive
github notifications.
https://github.com/autotest/autotest/issues/530
--
Regards,
--------------------------------------------------
Li Yang
No. 6 Wenzhu Road, Nanjing, 210012, China
TEL：+86+25-86630566-8526
FUJITSU INTERNAL：7998-8526
FAX：+86+25-83317685
EMail：[email protected]
--------------------------------------------------
This communication is for use by the intended recipient(s) only and may contain
information that is privileged, confidential and exempt from disclosure under
applicable law. If you are not an intended recipient of this communication, you
are hereby notified that any dissemination, distribution or copying hereof is
strictly prohibited. If you have received this communication in error, please
notify me by reply e-mail, permanently delete this communication from your
system, and destroy any hard copies you may have printed
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
