On 08/31/2012 02:33 AM, liyang wrote:
Hi Chris:
Thanks for your suggestion,I agree most of them.
But I think there is no need to change the following 2 places.
1.ret = libvirt_vm.virsh_domxml_from_native(vm_ref, ignore_status=True)
status = ret.exit_status
You mentioned "I'd recommend wrapping this in a try: / except: block, or
somehow otherwise making sure if there are problems, the libvirtd service
is restored as expected."
I had added a parameter "ignore_status= True" which can make the function
ignore exception.So I think the libvirtd service will be restored as
expected.
Yep, you're right. I was being overly paranoid :) Let's not worry
about this part.
2.def virsh_convxml(vm_name, guest_args):
You mentioned "I wonder if this function would be good to make more for
general use, and put into client/virt/libvirt_xml.py module."
In the virsh_convxml function, I haven't changed any XML file, just output
infomation this test needs. Maybe the name of the function is confusing,
and
I will change it. And I think the infomation outputed is not enough useful
for general use. Because of this, I think it not need to change.
Okay, fair enough, I respect your opinion. I will be first to say, I
have lots of ideas to share, but not all of them are very good :) It's
no problem with me if you don't think libvirt_xml is the right place.
That's my opinion, what do you think?
On 2012-8-30 1:52, Chris Evich wrote:
On 08/28/2012 06:13 AM, liyang wrote:
Hi Chris,Lucas:
This patch which includes 3 files tests "virsh domxml-from-native"
command.
The test contains six cases.
Li Yang (3):
virt/libvirt_vm.py: add virsh function for virsh domxml-from-native.
virt/subtests.cfg.sample: add config for virsh domxml-from-native.
tests/libvirt/tests: add test file for virsh domxml-from-native.
.../libvirt/tests/virsh_domxml_from_native.py | 104 ++++++++++++++++++++
client/virt/libvirt_vm.py | 8 ++
client/virt/subtests.cfg.sample | 31 ++++++
3 files changed, 143 insertions(+), 0 deletions(-)
create mode 100644
client/tests/libvirt/tests/virsh_domxml_from_native.py
Li,
I posted a full review of these patches on the github topic-issue you
opened (thanks!). Just mentioning it here in case you don't receive
github notifications.
https://github.com/autotest/autotest/issues/530
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
