Hi Plamen, I was looking into your lvsetup patches and I realized one odd thing: The patches remove the ability of the lvsetup test to be executed, ie, there's not a lvsetup class with a run_once method anymore. While it is fine to refactor the lvsetup operations and make them a library so other code can reuse it, we need to keep the lvsetup test functional. If we want to turn this into a library:
1) Isolate the functions like you did 2) Create a new file in the autotest tree, for example, client/lv_utils.py, with those functions 3) Rewrite the lvsetup class in terms of this new API, importing the lv_utils library and using the functions defined there. So I ask you to re-write the 2 patches you sent to fit into this general pattern, please? Thanks and sorry for the extra work! Lucas On Mon, Oct 29, 2012 at 8:38 AM, Plamen Dimitrov <[email protected]> wrote: > Hi, > > On Friday 21 September 2012 16:10:26 Plamen Dimitrov wrote: >> Signed-off-by: Plamen Dimitrov <[email protected]> >> --- >> client/tests/lvsetup/lvsetup.py | 499 >> ++++++++++++++++++++-------------------- 1 file changed, 251 insertions(+), >> 248 deletions(-) >> >> diff --git a/client/tests/lvsetup/lvsetup.py > > I have developed the code further and will send an updated patch > in a separate email. Feedback is appreciated :) > > Kind regards, > Plamen > > _______________________________________________ > Autotest-kernel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/autotest-kernel -- Lucas _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
