On 11/12/2012 08:12 AM, Plamen Dimitrov wrote:
On Friday 02 November 2012 17:29:19 you wrote:
Hi Plamen, I was looking into your lvsetup patches and I realized one
odd thing: The patches remove the ability of the lvsetup test to be
executed, ie, there's not a lvsetup class with a run_once method
anymore. While it is fine to refactor the lvsetup operations and make
them a library so other code can reuse it, we need to keep the lvsetup
test functional. If we want to turn this into a library:
1) Isolate the functions like you did
2) Create a new file in the autotest tree, for example,
client/lv_utils.py, with those functions
3) Rewrite the lvsetup class in terms of this new API, importing the
lv_utils library and using the functions defined there.
So I ask you to re-write the 2 patches you sent to fit into this
general pattern, please?
Thanks and sorry for the extra work!
Lucas
Sure, I sent the new patches separately because they concern different
submodules. I used your guess about putting "lv_utils" in the "client" folder
because I am not exactly sure where in the file hierarchy it would fit best.
Therefore, feel free to move it to a better place. Thank you for the suggested
standarts about the patches! Your help if very much appreciated.
I did look to the new patches, they both look good and were committed to
the next branches on both autotest.git and autotest-client-tests.git.
Cheers!
Lucas
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
