> From the web server you mean.

Well, sort of, but I think the web server is running as another user,
so changing
the owner bits won't fix anything. If we copy a directory as read-only, then
try to write in it, we'll be up the creek too?

> I thought about these issues too but AFAIK what
> you're describing should happen if we disable the chmod after a get_file()
> (used when receiving files from the client to the server) not after the
> send_file() (used to send files from the server to the client, and this is 
> what
> John's patch changes).

Aaaah, good point. missed that.

> Or maybe I missed a similar problem for send_file().

I think there's an implicit (maybe bad) assumption, that what we're sending
is better set up and known, what we get from the client could be any old
gunk.

M.
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to