> That is the general assumption; plus, in practice most of the things we're > sending don't need to be writable anyway, just readable, so even if lots of > stuff was being sent as read-only it probably wouldn't cause much of a > problem. > But in any case, I don't see how these send_file changes could be causing > the read-only problems you're seeing, since as a general rule all copies to > test machines use send_file while all copies from test machines use > get_file, and it looks like you're running into problems with the latter > case. None of these changes should've impacted the permissions on files > copied back; even if there was some sort of ripple effect (where the new > initial permissions of files sent to the remote machine were leading to > restricted permissions when copying them back) it shouldn't matter since the > get_file code still does an explicit chmod on the destinations.
Yup, cross-confusion on two changes on similar lines, sorry. The get file code does still seem to break on scp though. > I don't think this is a new problem; looking at my results directory, I do > see a mix of 444 and 644 files. But I see that exact same mix in older > results directories from a couple months ago. Odd. _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
