Couldn't we at least have some kind of message at the DEBUG level? I suppose it's not strictly necessary since we can tell that rsync is failing because scp is being used, but it would be useful to at least at the DEBUG level get some kind of detail from the CmdError.
Maybe this hints at a bigger problem; we shouldn't be wasting time trying to use rsync on systems where it's not available at all. On systems where rsync is available we really do want the verbose messages when it fails; on systems were it's not, we really shouldn't even be running it at all. -- John 2009/12/28 Martin Bligh <[email protected]> > The warning message when rsync fails back to scp is unnecessary, and > very polluting of the screen and logs when you work with systems without > rsync installed. Just drop the warning > > Signed-off-by: Martin J. Bligh <[email protected]> > > Index: abstract_ssh.py > =================================================================== > --- abstract_ssh.py (revision 4057) > +++ abstract_ssh.py (working copy) > @@ -211,9 +211,6 @@ > delete_dest, preserve_symlinks) > utils.run(rsync) > except error.CmdError, e: > - logging.warn("warning: rsync failed with: %s", e) > - logging.info("attempting to copy with scp instead") > - > # scp has no equivalent to --delete, just drop the entire dest > dir > if delete_dest and os.path.isdir(dest): > shutil.rmtree(dest) > @@ -278,9 +275,6 @@ > delete_dest, preserve_symlinks) > utils.run(rsync) > except error.CmdError, e: > - logging.warn("Command rsync failed with: %s", e) > - logging.info("Attempting to copy with scp instead") > - > # scp has no equivalent to --delete, just drop the entire dest > dir > if delete_dest: > is_dir = self.run("ls -d %s/" % dest, > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
