On Tue, Feb 2, 2010 at 9:36 AM, John Admanski <[email protected]> wrote:
> So, a couple comments on the general approach. > > 1) If these are basically a coherent, related set of functions which > are generally isolated from the rest of the utilities, maybe they > should be in a module of their own? I know it's a bit much, but in > general I don't like dumping even more functions into utils unless > they really have no other place to go. > They're kind of related but not sure if they belong to the same module. Reading the RTC has nothing to do with the power states. You need it, however, if you'd like to use the wake alarm to come out of suspend. So, maybe keep them in base_utils.py? > > 2) Instead of executing echo to write to files you it should be > calling write_one_line. > Will do. And I'll any exception pass through -- this would address Martin's concern. Darin > > On Tue, Feb 2, 2010 at 9:12 AM, Darin Petkov <[email protected]> wrote: > > This patch adds routines for reading the hardware real-time clock, > setting > > the > > RTC-based wake alarm and managing the system power state (standby, > > suspend-to-ram, suspend-to-disk). > > > > _______________________________________________ > > Autotest mailing list > > [email protected] > > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > > > >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
