Looks fine. It wouldn't hurt to see a patch to at least one test to have it make use of this function.
-- John On Fri, Aug 13, 2010 at 1:53 PM, Eric Li(李咏竹) <[email protected]> wrote: > Thanks for the quick response. Please take another look. > > > Index: client/common_lib/utils.py > =================================================================== > --- client/common_lib/utils.py (revision 4747) > +++ client/common_lib/utils.py (working copy) > @@ -1165,6 +1165,16 @@ > system('%s %s' % (configure, ' '.join(args))) > > > +def make(extra='', make='make', timeout=None, ignore_status=False): > + """ > + Run make, adding MAKEOPTS to the list of options. > + > + @param extra: extra command line arguments to pass to make. > + """ > + cmd = '%s %s %s' % (make, os.environ.get('MAKEOPTS', ''), extra) > + return system(cmd, timeout=timeout, ignore_status=ignore_status) > + > + > def compare_versions(ver1, ver2): > """Version number comparison between ver1 and ver2 strings. > > > On Fri, Aug 13, 2010 at 1:51 PM, John Admanski <[email protected]>wrote: > >> It should be consistent and use single-quoted strings for all of the >> string literals, but otherwise looks fine. >> >> -- John >> >> >> On Fri, Aug 13, 2010 at 1:49 PM, Eric Li(李咏竹) <[email protected]> wrote: >> >>> The idea here is to add -j option to most of our client tests at >>> pre-build stage. From our experiment, it reduced almost 50% of our build >>> time. >>> >>> The original author of this CL is CCed. >>> >>> >>> Index: client/common_lib/utils.py >>> =================================================================== >>> --- client/common_lib/utils.py (revision 4747) >>> +++ client/common_lib/utils.py (working copy) >>> @@ -1165,6 +1165,16 @@ >>> system('%s %s' % (configure, ' '.join(args))) >>> >>> >>> +def make(extra='', make='make', timeout=None, ignore_status=False): >>> + """ >>> + Run make, adding MAKEOPTS to the list of options. >>> + >>> + @param extra: extra command line arguments to pass to make. >>> + """ >>> + cmd = '%s %s %s' % (make, os.environ.get("MAKEOPTS", ""), extra) >>> >> + return system(cmd, timeout=timeout, ignore_status=ignore_status) >>> + >>> + >>> def compare_versions(ver1, ver2): >>> """Version number comparison between ver1 and ver2 strings. >>> >>> >>> -- >>> Eric Li >>> 李咏竹 >>> Google Kirkland >>> >>> >>> >> > > > -- > Eric Li > 李咏竹 > Google Kirkland > > >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
