On 01/03/2012 02:50 PM, Don Zickus wrote: > On Tue, Jan 03, 2012 at 02:17:00PM -0500, Chris Evich wrote: >> On 01/03/2012 02:08 PM, Don Zickus wrote: >>> On Tue, Jan 03, 2012 at 10:25:16AM -0500, Chris Evich wrote: >>>> Signed-off-by: Chris Evich<[email protected]> >>> >>> I am not sure you can do this as I relied on OptionParser (actually >>> parser.parse_args) to strip away autotest args (like --client_test_setup >>> or -H). Otherwise I believe CommandParser will fail because it doesn't >>> recognize those options. >>> >>> Cheers, >>> Don >> >> I believe it should still work. I didn't change the order of parsing, >> just the order of instantiation. By my reading, neither gobble up args >> until .parse_args() method runs. Though I'll double-check to be sure, >> since it's a valid concern. Thanks for pointing it out. > > Ah. Sorry about that. I believe you are right. I misread the code > (python isn't my strong suite :-) ). > > Might be interesting to run a quick test with something like > --client_test_setup to double check. > > Cheers, > Don
No need to apologize, double and triple-checking rarely hurts. I can't test the server-side, but just now for the client both sets of options seem to parse... # bin/autotest -t somethingdifferent --verbose --tap run libvirt DEBUG:root:Cleaning up previously found state file 15:02:12 INFO | Writing results to /usr/local/autotest/client/results/somethingdifferent 15:02:12 DEBUG| Initializing the state engine ...cut... -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
