Yeah, Chris gave a better fixing.
----- Original Message -----
From: "Lucas Meneghel Rodrigues" <look...@gmail.com>
To: "Chris Evich" <cev...@redhat.com>
Cc: autotest@test.kernel.org
Sent: Monday, April 2, 2012 10:31:27 PM
Subject: Re: [Autotest] [PATCH] Fix autotest results path
On Mon, Apr 2, 2012 at 10:24 AM, Lucas Meneghel Rodrigues
<look...@gmail.com> wrote:
> On Mon, Apr 2, 2012 at 10:21 AM, Chris Evich <cev...@redhat.com> wrote:
>> On 03/30/2012 11:48 PM, a...@redhat.com wrote:
>>> From: Alex Jia<a...@redhat.com>
>>>
>>> Running scan_results.py to get test result in autotest root
>>> directory instead of multi-layers subdirectory, it will be
>>> more friendly and convenient for users.
>>>
>>> Signed-off-by: Alex Jia<a...@redhat.com>
>>> ---
>>> client/tools/scan_results.py | 6 ++++--
>>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/client/tools/scan_results.py b/client/tools/scan_results.py
>>> index 71dddde..867c947 100755
>>> --- a/client/tools/scan_results.py
>>> +++ b/client/tools/scan_results.py
>>> @@ -90,9 +90,11 @@ def main(resfiles):
>>>
>>>
>>> if __name__ == "__main__":
>>> - import sys, glob
>>> + import os, sys, glob
>>> +
>>> + curr_path = os.getcwd()
>>> + resfiles = glob.glob("%s/client/results/default/status*" %curr_path)
>>>
>>> - resfiles = glob.glob("../../results/default/status*")
>>> if len(sys.argv)> 1:
>>> if sys.argv[1] == "-h" or sys.argv[1] == "--help":
>>> print "Usage: %s [result files]" % sys.argv[0]
>>
>> Hey,
>>
>> One question occurred to me: Is it okay to assume the 'default' job
>> name in the use-case context of this tool? i.e .Will this tool ever be
>> used on results generated from a job run by the autotest server or with
>> a different job-name?
>>
>> N.B. I've never used this tool, please forgive my ignorance if ^^^^
>> makes no sense.
>
> You know what, it does make sense :) I need to take this into account
> as well, the good thing is that it shouldn't be too difficult to make
> the tool display results for all jobs inside the client/results
> directory.
>
> /me looks...
In time, it was a trivial fix, see:
https://github.com/autotest/autotest/commit/5881fbfd594072ac5ce6891a793f2a3b5771fb76
Thanks for pointing it out!
--
Lucas
_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
