On 06/01/2012 02:32 AM, guyanhua wrote: > > > Gu Yanhua (2): > Add a param( default raise_error = True) in run function, thus when > virsh command gets a wrong param and isnt't expected to raise > error, we can set raise_error = False. > Adding two params (default raise_error = True, extra_param = "")in > virsh_cmd function, which can satisfy the basic use and test > the virsh command through diff params. Besides, I modified the > virsh_hostname function to satisfy more requirements. > > client/shared/base_utils.py | 4 ++-- > client/virt/libvirt_vm.py | 19 ++++++++++++------- > 2 files changed, 14 insertions(+), 9 deletions(-)
By the way...Please don't take feedback as we don't like these kinds of patches, this is not true. I'm actually really happy to see core libvirt code improvement and fixes like this, it's needed to move autotest forward. The hope is to help us all learn. We are leveraging community-wide expertise on everything, and result is better than one person could do on their own. So, "submit patch...feedback...re-write...loop" is just part of the process. Also, please feel free to review/comment on our patches/ideas too. Especially if you think they won't work for your needs. None of us can write perfect code with one try :D Thanks again. -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
