On 7/3/2012 11:22 PM, Chris Evich wrote: > On 07/03/2012 04:53 AM, Alex Jia wrote: >> On 07/03/2012 04:40 PM, Yu Mingfei wrote: >>> On 7/3/2012 4:26 PM, Alex Jia wrote: >>>> On 07/03/2012 04:13 PM, Yu Mingfei wrote: >>>>> On 7/3/2012 4:05 PM, Yu Mingfei wrote: >>>>>> , couldn't virsh edit do this? >>>>> With a new vm, it will be esay tobe cleaned up. >>>>> >>>>> >>>> It's not a good reason :), because you're writing a test case to test >>>> 'virsh edit', so you also >>> Thanks for you comment. >>> But I though you have mistaked "virsh edit" and "virt-edit".^_^ >>> I am testing virt-edit now, and I just need a new guest for test. >> Your function naming lets me confused ;) and don't suggest you to >> use 'a-b' naming style. > > This is just libvirt confusion lol :D There's virt-edit the command, and > the "edit" sub-command of virsh command. Not much we can do here except > be careful. Maybe add a comment flagging this so others don't have same > confusion? > >> >> If so, maybe, you may write a virsh_define() case to define a vm >> with different XML configuration then verify if your change is valid. > > This would be a good test to have, but not part of this patchset. Let's > look at adding this later since libvirt_vm already has a virsh_define > function ready, just no tests yet. Well, maybe I can give a more suitable testset for this patch, it tests undefine command of virsh. I will send this patch with that undefine testcases soon.^^
> >>> >>>> may use it to rename a vm firstly then return the new vm instead of >>>> directly editor vm's >>>> XML configuration then run virsh define. >>>> >>>> >>> >> >> _______________________________________________ >> Autotest mailing list >> Autotest@test.kernel.org >> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > -- Best Regards Yu Mingfei _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
